Support unused dependencies #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patryk27
requested review from
nmattia,
Anderssorby and
blitz
as code owners
Cargo stashes unused patches into a special section of the Cargo.lock file: ``` [[patch.unused]] name = "uuid" version = "1.4.1" source = "git+https://github.com/uuid-rs/uuid#50f70278de02c106650b8d6deb325dd59b5f2a24" ``` ... a section that we, currently, don't read. Ignoring that section causes the build to fail because even if the patch is unused, when the source is unavailable, Cargo tries to fetch it (which, understandably, is not possible inside the sandbox). This commit extends our logic so that we download both the "used" and "unused" dependencies. Closes #308.
Patryk27
force-pushed
the
pr-308/unused-patch
branch
from
cb0f53a
to
6c4b2ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo stashes unused patches into a special section of the Cargo.lock file:
... a section that we, currently, don't read.
Ignoring that section causes the build to fail because even if the patch is unused, when the source is unavailable, Cargo tries to fetch it (which, understandably, is not possible inside the sandbox).
This commit extends our logic so that we download both the "used" and "unused" dependencies.
Closes #308.