Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes nix-community/naersk#224 #322

Closed
wants to merge 1 commit into from
Closed

Fixes nix-community/naersk#224 #322

wants to merge 1 commit into from

Conversation

noebm
Copy link

@noebm noebm commented Apr 10, 2024

name will still be defined by mkDerivation when pname and version are defined and this is actually preferred according to RFC0035.

By defining pname, flake-utils.lib.mkApp will prefer this over name when calling the executable.

@noebm
Fixes #224
6d74f68 
`name` will still be defined by mkDerivation when `pname` and
`version` are defined and this is actually preferred according to
RFC0035.

By defining `pname`, `flake-utils.lib.mkApp` will prefer this over
`name` when calling the executable.
nmattia
nmattia approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @noebm !

Are you still using naersk? I was actually about to archive the repo, see discussion here: #214

@noebm
Copy link
Author

noebm commented Apr 11, 2024

Oh I just started using it. So you would suggest switch to crane?

@nmattia
Copy link
Collaborator

nmattia commented Apr 11, 2024

So you would suggest switch to crane?

Definitely! Naersk is very much unmaintained at this point!

@noebm noebm closed this by deleting the head repository Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmattia nmattia nmattia approved these changes

@Patryk27 Patryk27 Awaiting requested review from Patryk27 Patryk27 is a code owner

@Anderssorby Anderssorby Awaiting requested review from Anderssorby Anderssorby is a code owner

@blitz blitz Awaiting requested review from blitz blitz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noebm @nmattia