Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .cargo-home/config warning on nightly, bump probe-rs #325

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

exFalso
Copy link
Contributor

@exFalso exFalso commented Apr 16, 2024

This PR fixes the nightly warning

warning: `/build/probe-rs-src/.cargo-home/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`

Also bumps the probe-rs sources and the rust nightly version used for testing it

@nmattia
Copy link
Collaborator

nmattia commented Apr 18, 2024

Thank you @exFalso !

Out of curiosity, are you actively using naersk? I'm planning on marking it as deprecated: #214 (comment)

@exFalso
Copy link
Contributor Author

exFalso commented Apr 18, 2024

Oh hmm hmm, yes we've been using it for quite some time now(2020 i think?).

At the time we picked it, it was the only nix-cargo project that worked at all with our setup. We use nightly rust with special targets (SGX and WASM), we have workspaces, local dependencies, forks of dependencies, git dependencies etc. And we wanted plain cargo to "just work" during development. None of the other tools worked, although crane did not exist at the time.

naersk just sort of works in its current state (I guess besides these smaller oddities as rust evolves over time), so we probably won't spend dev resources on a switch any time soon. If you do deprecate it, then thank you for the project and the maintenance effort so far! It's been (and still is) one of the most important workhorses for our builds.

build.nix Show resolved Hide resolved
nmattia
nmattia previously approved these changes Apr 18, 2024
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor suggestion

@nmattia
Copy link
Collaborator

nmattia commented Apr 18, 2024

It's been (and still is) one of the most important workhorses for our builds.

That's very nice to hear!

Then I might keep it around for a bit longer. Might be a good idea to give e.g. crane a try as it might prove more future proof though. I'm actually surprised to hear that naersk can somewhat keep up with recent rust changes; I think it says a lot about the backwards compatibility of the rust platform!

Co-authored-by: Nicolas Mattia <[email protected]>
@nmattia nmattia merged commit c503759 into nix-community:master Apr 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants