Make --top-level the default behavior of nix-locate
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
force-pushed
the
top-level-default
branch
from
42cf33b
to
2b48ed1
Compare
It happens pretty often to me that I'm trying to find out which packages contain a certain header file (e.g. `unistd.h`). In those cases I usually don't care at all about which e.g. FHS env has this header as well. I can't remember a single time where this was actually helpful, so I'm questioning whether this is a sensible default. I'll use this patch in my own setup for now, but I thought I could suggest it here as well.
|
Rebased onto latest master now. |
|
Looks good to me ! Waiting for this to get in... |
|
Bump, this would be nice to get in! I've already used it through a personal patch and it works like a charm. EDIT: sorry for the cross-links, GitHub doesn't like that I force pushed to update the commit description. |
Frontear
added a commit
to Frontear/dotfiles
that referenced
this pull request
Nov 15, 2024
This is part of a PR over at nix-community/nix-index#243 which makes --top-level a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Frontear
added a commit
to Frontear/dotfiles
that referenced
this pull request
Nov 15, 2024
This is part of a PR over at https://github . com/nix-community/nix-index/pull/243 which makes `--top-level` a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Frontear
added a commit
to Frontear/dotfiles
that referenced
this pull request
Nov 15, 2024
This is part of a PR over at nix-community/nix-index#243 which makes `--top-level` a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens pretty often to me that I'm trying to find out which packages contain a certain header file (e.g.
unistd.h). In those cases I usually don't care at all about which e.g. FHS env has this header as well.I can't remember a single time where this was actually helpful, so I'm questioning whether this is a sensible default. I'll use this patch in my own setup for now, but I thought I could suggest it here as well.
cc @RaitoBezarius @figsoda @bennofs