fix: headings with ids get escaped by comrak #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that headings with id got escaped by the default formatter of comrak.
# heading {#some-id}
-># heading {\#some-id}
Unfortunately it seems there is no option or other crate that allows easy bi-directional serializing of common mark.
All other options i investigated require an incredible amount of work. (i.e. pulldown-cmark requires wiriting a complete engine, that handle all ast cases and sub node cases)
I fixed that issue now by implementing a custom formatter, that uses comrak::format_commonmark for all nodes except for headings.
Fixes: NixOS/nixpkgs#303330.