Network resource support for libvirt backend #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
It fails deploying to a remote libvirtd if the primary network is limited to be a NAT or isolated network. Also in order to keep backward compatibility, it is better to keep the first interface as primary.
onixie
force-pushed
the
network-resource-support
branch
from
4047f36
to
1178e08
Compare
|
Hi there, would you mind rebasing on top of master? There have been some substantial changes to make it work with NixOps master / the upcoming NixOps 2.0. |
|
Hi @grahamc |
onixie
force-pushed
the
network-resource-support
branch
from
d670b60
to
5084482
Compare
onixie
force-pushed
the
network-resource-support
branch
from
5084482
to
cfee923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar like the PR nix-community/nixops-vbox#2 for virtualbox backend, the changes here are to extend network capabalities for libvirt backend following the idea I proposed at NixOS/nixops#1223.
Though the implementation is quite different from virtualbox backend, I tried to keep the name as well as the layout of nix module options consistent between the two backends. I also add some libvirt specific options such as various modes for macvtap device, virtualport for bridge device such as Open vSwitch, etc.
I have done some simple tests with commands like deploy (and redeploy), start, stop and destroy.
I also tried to keep the backward compatibilities though I don't know if my tests could cover all such cases.
Glad to have you review and maybe more tests and trials.
Thanks.