Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait 60 minutes for ofborg #370

Merged
merged 1 commit into from
Dec 10, 2023
Merged

wait 60 minutes for ofborg #370

merged 1 commit into from
Dec 10, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 27, 2023

Waiting only 15 minutes doesn't give enough time for ofborg to work through the queue.

Copy link
Member

@rhendric rhendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there non-infra users of batch update mode?

If not, since infra is running with this patch with or without us, I don't see a reason not to merge this.

@zowoq
Copy link
Contributor Author

zowoq commented Nov 28, 2023

Are there non-infra users of batch update mode?

AFAIK, no.

If not, since infra is running with this patch with or without us, I don't see a reason not to merge this.

It is unfortunate that nixpkgs/ofborg performance seems to have gotten much worse the last couple of months but there has been a bit of discussion about it recently so hopefully can revert this at some point.

@ryantm
Copy link
Collaborator

ryantm commented Dec 10, 2023

I want to be a good citizen, but I feel like waiting for OfBorg is kind of hiding the problem. This is blocking legitimate updates. Maybe we need to do something more drastic like batch updates...

@ryantm ryantm merged commit 1505f5c into nix-community:main Dec 10, 2023
1 check passed
@zowoq zowoq deleted the wait60 branch December 10, 2023 22:50
@zowoq
Copy link
Contributor Author

zowoq commented Dec 10, 2023

The changes are spread of a few PRs but I think NixOS/nixpkgs#269403 in the main one, it should help with the slow evals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants