Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an infinite recursion due to setuptools and setuptools-scm #744

Conversation

SemMulder
Copy link
Contributor

There is a bootstrapping issue when trying to build setuptool-scm, since building it (transitively) requires setuptools-scm itself. The same holds for setuptools. This "fixes" that by removing any references to setuptools and setuptools-scm from the entries gathered from poetry.lock with the idea that we should default to setuptools and setuptools-scm from nixpkgs.

This fixes #648, albeit quite ugly.

A better approach would be to build the versions of setuptools and setuptools-scm specified in poetry.lock using whatever setuptools and setuptools-scm is in nixpkgs, and use setuptools and setuptools-scm from poetry.lock afterwards. However, I'm not sure how to best go about this, since it would require a separate Python environment.

@cpcloud
Copy link
Collaborator

cpcloud commented Oct 9, 2022

I think this can be closed in light of #736 and related follow ups.

@adisbladis adisbladis closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite recursion on setuptools with Poetry 1.2 beta
3 participants