Expose SeekData and SeekHole on all Linux targets #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Aug 17, 2020
|
Musl doesn't define these constants in its headers, which is why they are not defined by the libc crate. See rust-lang/libc#319. |
|
Yes it does. At least, they're in the libc crate now. And if they weren't, then it still wouldn't be right for Nix to define them. |
|
I had an old checkout of libc and didn't notice that |
|
Looks good now! Could you also please add a CHANGELOG entry? |
These were previously missing on musl and mips targets because of missing definitions in the libc crate.
Amanieu
changed the title
|
Done. |
|
Merge conflict. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously missing on musl and mips targets because of
missing definitions in the libc crate.