-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SO_RXQ_OVFL socket option (android/fuchsia/linux) #1455
Conversation
922ef34
to
2335050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add a CHANGELOG entry. Also, what about Android and Fuchsia? libc defines this constant for them.
d54f90c
to
cd8f7f7
Compare
I added CHANGELOG entry and addressed other comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
1455: Support SO_RXQ_OVFL socket option (android/fuchsia/linux) r=asomers a=junhochoi This PR implements support of RXQ_OVFL flag and parsing ControlMessage to get the packet drop counter of UDP socket. Co-authored-by: Junho Choi <[email protected]>
Build failed: |
The tests are failing due to a just-landed PR on head. |
rebased to master and pushed a fix. |
@asomers the build is green. should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
1455: Support SO_RXQ_OVFL socket option (android/fuchsia/linux) r=asomers a=junhochoi This PR implements support of RXQ_OVFL flag and parsing ControlMessage to get the packet drop counter of UDP socket. Co-authored-by: Junho Choi <[email protected]>
Timed out. |
bors retry |
Merge conflict. |
This PR implements support of RXQ_OVFL flag and parsing ControlMessage to get the packet drop counter of UDP socket.
rebased to master again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
This PR implements support of RXQ_OVFL flag and parsing ControlMessage
to get the packet drop counter of UDP socket.