Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
unistd::close_range()
#2153Add
unistd::close_range()
#2153Changes from 1 commit
82d3c02
5a380d4
46bd488
3e5d881
6129a9e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be using raw syscalls here. They lack type safety, and they aren't portable. Instead, you should add
close_range
in a PR to libc. Then , once that merges, you can add support to Nix. If you're ambitious, you might consider addingclosefrom
while you're at it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. I was following the precedent of other functions in this file (eg:
gettid
,execveat
, andpivot_root
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
gettid()
andexecveat()
, see this issue #2156, forpivot_root
, there seems to be no libc wrapper for it, so we have to use the syscall directly.close_range()
has a wrapper in glibc (now sure about other libcs), can you please add it to the upstream libc crate and then we can add it in nixThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, that makes sense.
For my use case I need to statically link and are therefore using musl which does not yet implement
close_range()
.