Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl target needs std::mem now #381

Merged
merged 1 commit into from
Jun 30, 2016
Merged

musl target needs std::mem now #381

merged 1 commit into from
Jun 30, 2016

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Jun 29, 2016

Closes #325.

@fiveop
Copy link
Contributor Author

fiveop commented Jun 30, 2016

This build and the build for PR #379 only failed because of timeouts on mac builds. This is probably due to Travis-CI's recent problems with MacOS builds. Does anyone of us have the privileges to trigger a rebuild without us having to reopen the PR or push a change?

@fiveop
Copy link
Contributor Author

fiveop commented Jun 30, 2016

Since this change should not have any impact on our CI builds, could you, @posborne, recheck that it builds properly for x86_64-unknown-linux-musl now?

@utkarshkukreti
Copy link
Contributor

I have triggered a rebuild for this PR: https://travis-ci.org/nix-rust/nix/builds/141162721

I think you should be able to do it too from https://travis-ci.org/nix-rust/nix/pull_requests.

@fiveop
Copy link
Contributor Author

fiveop commented Jun 30, 2016

Thanks. I do not see any UI element on that page, that would allow me to rebuild a previous build.

@utkarshkukreti
Copy link
Contributor

Are you logged in on Travis? Click on a PR title on that page and you should see a "Restart Build" icon on the right like this:

screen shot 2016-06-30 at 10 33 53 pm

@utkarshkukreti
Copy link
Contributor

@homu r+

@homu
Copy link
Contributor

homu commented Jun 30, 2016

📌 Commit 19811a5 has been approved by utkarshkukreti

@homu
Copy link
Contributor

homu commented Jun 30, 2016

⚡ Test exempted - status

@homu homu merged commit 19811a5 into nix-rust:master Jun 30, 2016
homu added a commit that referenced this pull request Jun 30, 2016
musl target needs std::mem now

Closes #325.
@fiveop fiveop deleted the fix_musl branch July 21, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants