-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/socket: add UnixAddr abstract name getter #785
Conversation
03c99a6
to
0d3626a
Compare
It looks like master is currently broken due to this libc change: rust-lang/libc#787. I also realized I forgot the relevant CHANGELOG entry, I'll add it on the next rebase once master is fixed. Reviews and comments still welcome in the meanwhile. |
Hi @lucab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though new_abstract
and as_abstract
compile fine everywhere, they won't work except on Linux. So they should probably be guarded with a #[cfg(target_os = "linux")]
0d3626a
to
b54c9a4
Compare
PTAL on second iteration:
@asomers I did as you suggested but I am not a fan of it, because |
@lucab The
|
b54c9a4
to
fbcddf6
Compare
This introduces an `as_abstract()` getter to `UnixAddr` in order to retrieve the name of an abstract unix socket. This also adds tests around abstract addresses and clarify docs, adding explicit semantics.
fbcddf6
to
02f2ede
Compare
@asomers I'm fine with your feedback, I don't want to keep bikeshedding this further. I've double-checked Android docs and then added support for it as well, PTAL. |
Thanks for your submission. bors r+ |
This introduces an
as_abstract()
getter toUnixAddr
in order toretrieve the name of an abstract unix socket.
This also adds tests around abstract addresses and clarify docs,
adding explicit semantics.