Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamic component support in [email protected] #13

Closed
wants to merge 1 commit into from
Closed

Use dynamic component support in [email protected] #13

wants to merge 1 commit into from

Conversation

TehShrike
Copy link
Collaborator

@TehShrike
Copy link
Collaborator Author

Right now this pull request only conflicts on package-lock.json, but it will conflict with a lot more once #14 is merged.

I'd recommend re-implementing this against master after #14 is merged.

@njbotkin
Copy link
Owner

Thanks for the suggestion. I wasn't sure how to handle this.

njbotkin added a commit that referenced this pull request Dec 14, 2017
@njbotkin
reimplement pr #13, getting svelte's dynamic components
e892519
@njbotkin njbotkin closed this Dec 14, 2017
@njbotkin njbotkin mentioned this pull request Dec 15, 2017
Merged
njbotkin added a commit that referenced this pull request Dec 15, 2017
@njbotkin
Merge pull request #15 from njbotkin/dynamic-components
d88308e 
reimplement pr #13, getting svelte's dynamic components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TehShrike @njbotkin