Fix wrong memory addresses due to not accounted GROUPR offset #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GROUPR writes gendf data in a compact way and let us know, what the offset is. The dlayxs part of CCCR loops over the full energy group range in container variable `a` where it should loop only until the offset. Thereby, on chance uninitialized or invalid memory may be addressed and may lead at best to a crash or simply runs without error but resulting in values like 1.E+44 for delayed spectra. This commit introduces the offset and corrects 2 loops. Moreover, a check is introduced if the requested memory fits into the `a` variable. The `a` size variable `isiza` was moved to a parameter statement and renamed to account for 4 byte and 8 byte equivalence'd variables.
|
To see the erroneous bevavior, one can take input.cccr_u232_361.txt with ENDF6 data of U-232. It uses the SHEM-361 group structure. |
whaeck
requested changes
Sep 15, 2022
There was a problem hiding this comment.
Just a few minor questions that we should address before approving this.
I have asked @nathangibson14 to have a look if he has some time - but I think these changes are pretty straight forward.
added 4 commits
September 15, 2022 19:24
* Get low energy offset the NJOY way * Let last loop in `subroutine dldata` go over full `ngn` (error introduced during this PR)
whaeck
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
I think this is good to go. I'm waiting for some feedback from @nathangibson14 before I merge but I think we won't need more changes here.
I did verify the specs for the delayed neutron data in the GENDF file and that -1 does indeed need to be taken into account. Putting the comment there makes it easier to understand as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GROUPR writes gendf data in a compact way and let us know, what the offset is.
The dlayxs part of CCCR loops over the full energy group range in container variable
awhere it should loop only until the offset. Thereby, on chance uninitialized or invalid memory may be addressed and may lead at best to a crash or simply runs without error but resulting in values like 1.E+44 for delayed spectra.This commit introduces the offset and corrects 2 loops. Moreover, a check is introduced if the requested memory fits into the
avariable. Theasize variableisizawas moved to a parameter statement and renamed to account for 4 byte and 8 byte equivalence'd variables.