Skip to content

Commit

Permalink
Issue eclipse#162 align with standards for MP Config property names
Browse files Browse the repository at this point in the history
  • Loading branch information
njr-11 committed Jun 6, 2019
1 parent 7c7ac85 commit 2c93e18
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public interface Builder {
* by the specification that defines the context type or by a related
* MicroProfile specification.</p>
*
* <p>The MicroProfile Config property, <code>ManagedExecutor/cleared</code>,
* <p>The MicroProfile Config property, <code>mp.context.ManagedExecutor.cleared</code>,
* establishes a default that is used if no value is otherwise specified.
* The value of the MicroProfile Config property can be the empty string
* or a comma separated list of context type constant values.</p>
Expand All @@ -212,7 +212,7 @@ public interface Builder {
* by the specification that defines the context type or by a related
* MicroProfile specification.</p>
*
* <p>The MicroProfile Config property, <code>ManagedExecutor/propagated</code>,
* <p>The MicroProfile Config property, <code>mp.context.ManagedExecutor.propagated</code>,
* establishes a default that is used if no value is otherwise specified.
* The value of the MicroProfile Config property can be the empty string
* or a comma separated list of context type constant values.</p>
Expand All @@ -237,7 +237,7 @@ public interface Builder {
* <p>The default value of <code>-1</code> indicates no upper bound,
* although practically, resource constraints of the system will apply.
* You can switch the default by specifying the MicroProfile Config
* property, <code>ManagedExecutor/maxAsync</code>.</p>
* property, <code>mp.context.ManagedExecutor.maxAsync</code>.</p>
*
* @param max upper bound on async completion stage actions and executor tasks.
* @return the same builder instance upon which this method is invoked.
Expand All @@ -253,7 +253,7 @@ public interface Builder {
* <p>The default value of <code>-1</code> indicates no upper bound,
* although practically, resource constraints of the system will apply.
* You can switch the default by specifying the MicroProfile Config
* property, <code>ManagedExecutor/maxQueued</code>.</p>
* property, <code>mp.context.ManagedExecutor.maxQueued</code>.</p>
*
* @param max upper bound on async actions and tasks that can be queued.
* @return the same builder instance upon which this method is invoked.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ interface Builder {
* by the specification that defines the context type or by a related
* MicroProfile specification.</p>
*
* <p>The MicroProfile Config property, <code>ThreadContext/cleared</code>,
* <p>The MicroProfile Config property, <code>mp.context.ThreadContext.cleared</code>,
* establishes a default that is used if no value is otherwise specified.
* The value of the MicroProfile Config property can be the empty string
* or a comma separated list of context type constant values.</p>
Expand All @@ -156,7 +156,7 @@ interface Builder {
* by the specification that defines the context type or by a related
* MicroProfile specification.</p>
*
* <p>The MicroProfile Config property, <code>ThreadContext/propagated</code>,
* <p>The MicroProfile Config property, <code>mp.context.ThreadContext.propagated</code>,
* establishes a default that is used if no value is otherwise specified.
* The value of the MicroProfile Config property can be the empty string
* or a comma separated list of context type constant values.</p>
Expand All @@ -183,7 +183,7 @@ interface Builder {
* by the specification that defines the context type or by a related
* MicroProfile specification.</p>
*
* <p>The MicroProfile Config property, <code>ThreadContext/unchanged</code>,
* <p>The MicroProfile Config property, <code>mp.context.ThreadContext.unchanged</code>,
* establishes a default that is used if no value is otherwise specified.
* The value of the MicroProfile Config property can be the empty string
* or a comma separated list of context type constant values. If a default
Expand Down
14 changes: 7 additions & 7 deletions spec/src/main/asciidoc/mpconfig.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ For example, you could specify MicroProfile Config properties as follows to esta

[source, text]
----
ManagedExecutor/propagated=Remaining
ManagedExecutor/cleared=Transaction
ManagedExecutor/maxAsync=10
ManagedExecutor/maxQueued=-1
mp.context.ManagedExecutor.propagated=Remaining
mp.context.ManagedExecutor.cleared=Transaction
mp.context.ManagedExecutor.maxAsync=10
mp.context.ManagedExecutor.maxQueued=-1
----

With these defaults in place, the application can create a `ManagedExecutor` instance without specifying some of the configuration attributes,
Expand All @@ -42,9 +42,9 @@ As another example, the following MicroProfile Config properties establish defau

[source, text]
----
ThreadContext/propagated=
ThreadContext/cleared=Security,Transaction
ThreadContext/unchanged=Remaining
mp.context.ThreadContext.propagated=
mp.context.ThreadContext.cleared=Security,Transaction
mp.context.ThreadContext.unchanged=Remaining
----

With these defaults in place, the application can create a `ThreadContext` instance without specifying some of the configuration attributes,
Expand Down
16 changes: 8 additions & 8 deletions spec/src/main/asciidoc/overview.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,13 @@ MicroProfile Config properties can be used to specify defaults for configuration
Here is an example that includes all of the available attributes that can be defaulted:

----
ManagedExecutor/propagated=Security,Application
ManagedExecutor/cleared=Remaining
ManagedExecutor/maxAsync=10
ManagedExecutor/maxQueued=-1
ThreadContext/propagated=
ThreadContext/cleared=Security,Transaction
ThreadContext/unchanged=Remaining
mp.context.ManagedExecutor.propagated=Security,Application
mp.context.ManagedExecutor.cleared=Remaining
mp.context.ManagedExecutor.maxAsync=10
mp.context.ManagedExecutor.maxQueued=-1
mp.context.ThreadContext.propagated=
mp.context.ThreadContext.cleared=Security,Transaction
mp.context.ThreadContext.unchanged=Remaining
----

Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,13 @@ public static WebArchive createDeployment() {
.addClass(MPConfigTest.class)
.addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml")
.addAsWebInfResource(new StringAsset(
"ManagedExecutor/maxAsync=1\n" +
"ManagedExecutor/maxQueued=4\n" +
"ManagedExecutor/propagated=Label,ThreadPriority\n" +
"ManagedExecutor/cleared=Remaining\n" +
"ThreadContext/cleared=Buffer\n" +
"ThreadContext/propagated=\n" +
"ThreadContext/unchanged=Remaining"),
"mp.context.ManagedExecutor.maxAsync=1\n" +
"mp.context.ManagedExecutor.maxQueued=4\n" +
"mp.context.ManagedExecutor.propagated=Label,ThreadPriority\n" +
"mp.context.ManagedExecutor.cleared=Remaining\n" +
"mp.context.ThreadContext.cleared=Buffer\n" +
"mp.context.ThreadContext.propagated=\n" +
"mp.context.ThreadContext.unchanged=Remaining"),
"classes/META-INF/microprofile-config.properties")
.addAsLibraries(fakeContextProviders);
}
Expand Down

0 comments on commit 2c93e18

Please sign in to comment.