-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1.0 #70
Release 0.1.0 #70
Conversation
Weird that crew workers are failing on ubuntu with devel R only. I can try to spin up a docker container and test this out interactively (e.g. set up the crew controller to save out logs) |
I couldn't reproduce the error on r-devel with rocker/geospatial:devel. However, I got a different test error from that container:
I wonder if this has something to do with differences in GDAL versions? |
That is a bit strange re the crew workers! Thanks for checking that out in a docker container. 3.0.4 is 4 years old, it makes me think that maybe we should set a minimum version GDAL version in the DESCRPTION under SystemReqs and then also maybe manage that in GH actions, where we can provide a range of GDAL versions |
Can confirm writing SOZip shapefile requires GDAL >= 3.7. Not sure if we should have a fallback to using utils::zip() (non-SOZip) in this case, or whether it should be an error/test should be skipped on old GDAL |
Still looking into the error with the crew containers. I'm going to see if I can set up the controller to save worker logs in a way that'll be accessible as an artifact from GitHub actions—that should be useful going forward. GDAL 3.7 was released only about a year ago, so it seems maybe not ideal to require >= 3.7, so it might be a good idea to fallback to |
Hmm, I'm stumped. Nothing should have changed with those crew tests in this PR! It's hard to debug because |
Well, looks like whatever was going on was a temporary GitHub issue. |
Resolves #68