Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#800 Added IgBoSpeech to Navbar #804

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VarunHarish98
Copy link

@VarunHarish98 VarunHarish98 commented Aug 14, 2024

Describe your changes

  1. Added the mentioned button (igboSpeech) to NavBar, which on clicked redirects to url (https://speech.igboapi.com) .

Issue ticket number and link

#800

Motivation and Context

How Has This Been Tested?

a. 2 TestCases

  1. NavigationOptions.test.tsx (tests\Navbar)
  2. NavigationOptions.test.tsx (\pages\components\Navbar_tests_)

Screenshots (if appropriate):

  1. Display on NavBar
    image
  2. Redirect to mentioned link on click
    image

Copy link
Collaborator

@ijemmao ijemmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just one comment. Please feel free to clarify why you updated the test file if you feel that it's necessary to give me more context on your changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! You don't need to change the imported component from NavigationMenu to NavigationOptions. We have another test file called NavigationOptions.test.tsx that you want to update.

Please revert these changes in this file and make these changes in NavigationOptions.test.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants