md-cluster: remove inappropriate try_module_get from join()

md_setup_cluster already calls try_module_get(), so this try_module_get isn't needed. Also, there is no matching module_put (except in error patch), so this leaves an unbalanced module count. Signed-off-by: NeilBrown <[email protected]>
nkskjames · Aug 31, 2015 · 18b9f67 · 18b9f67
1 parent 6022e75
commit 18b9f67
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
@@ -687,9 +687,6 @@ static int join(struct mddev *mddev, int nodes)
 	int ret, ops_rv;
 	char str[64];
 
-	if (!try_module_get(THIS_MODULE))
-		return -ENOENT;
-
 	cinfo = kzalloc(sizeof(struct md_cluster_info), GFP_KERNEL);
 	if (!cinfo)
 		return -ENOMEM;
@@ -771,7 +768,6 @@ static int join(struct mddev *mddev, int nodes)
 		dlm_release_lockspace(cinfo->lockspace, 2);
 	mddev->cluster_info = NULL;
 	kfree(cinfo);
-	module_put(THIS_MODULE);
 	return ret;
 }