Fix webpack aliased suggestions being filtered out #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So I noticed that no suggestions show up when I try and import from a webpack alias. For example, given the following Webpack config:
If I type
import App from "~/"
then I would expect to see the children ofsrc/
, but in fact I see nothing. It looks like the problem is that the suggestions are being filtered based onprefix
, butprefix
doesn't match any results since they've been transformed by the alias.So my solution is to copy the
massagePrefix
behaviour fromLocalLookup
intoWebpackLookup
, i.e. suggestions will only be matched on the last part of the path. I can't see any reason why this would be a problem, but hopefully someone more familiar with the codebase can confirm that.