-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Warning] -Wparentheses on line 555 on single_include #1319
Labels
Milestone
Comments
Thanks for reporting! I already fixed this two branches that should be merged soon. I'll leave this issue open until the fix reached the develop branch. |
Thanks |
Before fixing it - @theodelrieu - is static constexpr bool value =
std::is_constructible<typename ConstructibleObjectType::key_type,
typename object_t::key_type>::value and
std::is_same<typename object_t::mapped_type,
typename ConstructibleObjectType::mapped_type>::value or
(has_from_json<BasicJsonType,
typename ConstructibleObjectType::mapped_type>::value or
has_non_default_from_json <
BasicJsonType,
typename ConstructibleObjectType::mapped_type >::value); correct and only needs parentheses? |
This is now fixed in |
nlohmann
added
the
solution: proposed fix
a fix for the issue has been proposed and waits for confirmation
label
Oct 30, 2018
Hurray, thanks a lot |
loumalouomega
added a commit
to KratosMultiphysics/Kratos
that referenced
this issue
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The following warning appears (I am using Clang 6.0):
The line on the code is:
json/single_include/nlohmann/json.hpp
Line 555 in f102df3
Thank you very much
The text was updated successfully, but these errors were encountered: