-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases 3.6.0 and 3.6.1 don't build on conda / windows #1536
Comments
That is odd, because the MSVC 2015 build runs successfully at our AppVeyor, see https://ci.appveyor.com/project/nlohmann/json/builds/23234117. |
Note that this only occurs with 3.6.x. Previous versions of |
The compilation error is in file |
It would be great to look at the Maybe I would suggest removing the inheritance from |
@theodelrieu Good point, I'll try the |
@SylvainCorlay Could you try whether baaa2a4 builds? |
The issue appears only when building
|
@mistersandman Thanks for the info! As you seem to have access to MSVC (I don't...), could you please check whether baaa2a4 also works? |
I just checked and it works! Your fix is cleaner than mine 😃 |
The question for @SylvainCorlay remains, whether it is even necessary for his case to build the test suite. If the goal is only to install the library, there's no need for it. Building the test suite can be turned off by adding |
Hey, thanks for the responses, I am busy for the next couple of hours but will respond after. |
@SylvainCorlay Does baaa2a4 fix the issue? |
Trying it out now. |
Including your patch in the recipe appears to be fixing the compilation issue! |
3.6.0 and 3.6.1 are now on conda-forge! |
Thanks a lot for your efforts! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
I am the maintainer of the nlohman_json package on conda-forge. The package for the latest releases don't build on windows (VS 2015)
Please describe the steps to reproduce the issue. Can you provide a small but working code example?
The logs for the failing builds are available
Which compiler and operating system are you using? Is it a supported compiler?
MSVC / Windows / (VS 2015)
develop
branch?Released version.
The compilation error occurs while building the tests, as per the logs above.
The text was updated successfully, but these errors were encountered: