Tests/cmake external data #1251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, CI jobs timed out... |
|
fwiw at kitware we're beginning to transition away from ExternalData in favor of git-lfs. It's got it's own pluses and minuses but the broader git community as a whole seems to be moving that way. Just something to consider... |
|
This could be a great alternative indeed, I'll try to find some time to take a look. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
state: stale
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #1185 and affiliates, by putting every data file (test and benchmarks) somewhere else (currently one of my repositories...), and fetching them with CMake
ExternalDatamodule.The current repo size is 22MB, down from more than 150MB.
There are more than 1K files to download when running tests, which is a bit annoying. The CI will most likely be slower.
We could refactor the tests/cmake files and dedicate a specific CI job for tests requiring data files, and only trigger the 1K download when launching those specific tests.
Last but not least, we have to decide where to store those files.
Let me know what you think!
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filesingle_include/nlohmann/json.hpp. The whole process is described here.