Do proper endian conversions #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template. |
request-info
bot
added
the
state: needs more info
andreas-schwab
changed the title
jaredgrubb
reviewed
Feb 21, 2019
|
@andreas-schwab Thanks for the PR. Can you address the questions above? |
This fixes all testsuite failures on big endian hosts.
|
Forgot to amend the commit. |
nlohmann
requested changes
Mar 13, 2019
nlohmann
added
release item: 🐛 bug fix
and removed
state: needs more info
|
Thanks a lot! Sorry for my confusion... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all testsuite failures on big endian hosts.
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:PowerPC/nlohmann_json/standard/ppc64