Abstract object/array type out so that arbitrary types can be used #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR. Can you please make the changes also to file |
|
@erichkeane Sorry for not coming back to this PR earlier. There were quite some fixes on the MSVC side, so I would like to ask you to resubmit the PR to work on the latest version. |
1 similar comment
|
@erichkeane Sorry for not coming back to this PR earlier. There were quite some fixes on the MSVC side, so I would like to ask you to resubmit the PR to work on the latest version. |
|
Sure! I can rebase these. |
|
Closed here - overworked PR at #209. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @palacaze in #161, this allows using an unordered_map
as well as anything that obeys the template<K,V> type for the object
type or template for the array type.