Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: install pkg-config file relative to current_binary_dir #2318

Merged
merged 2 commits into from
Jul 28, 2020

Commits on Jul 27, 2020

  1. cmake: install pkg-config file relative to current_binary_dir

    When the testsuite is enabled, the "cmake_add_subdirectory" test
    adds a second copy of the project into the build configuration, and the
    project files are installed twice.
    
    This becomes super problematic when it tries to install a file from
    CMAKE_BINARY_DIR which is only available in CMAKE_CURRENT_BINARY_DIR
    and bombs out with the following error message:
    
    ```
    [...]
    -- Installing: <DESTDIR>/usr/lib/cmake/nlohmann_json/nlohmann_jsonTargets.cmake
    CMake Error at test/cmake_add_subdirectory/nlohmann_json/cmake_install.cmake:73 (file):
      file INSTALL cannot find
      "......./nlohmann-json/builddir/test/cmake_add_subdirectory/nlohmann_json.pc":
      No such file or directory.
    Call Stack (most recent call first):
      test/cmake_add_subdirectory/cmake_install.cmake:47 (include)
      test/cmake_install.cmake:49 (include)
      cmake_install.cmake:94 (include)
    ```
    eli-schwartz committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    aa06a47 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. 1 Configuration menu
    Copy the full SHA
    7d01a9e View commit details
    Browse the repository at this point in the history