Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(partial) msvc support #34

Closed
wants to merge 2 commits into from
Closed

(partial) msvc support #34

wants to merge 2 commits into from

Conversation

Zoadian
Copy link

@Zoadian Zoadian commented Feb 4, 2015

some changes to support compilation with msvc120
I used .h and .cc files directly without cmake.

also line 2374 is probably wrong

so this is just the first step to support msvc.

cheader update to compile with msvc
source updates to compile with msvc
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 90865cc on Zoadian:master into c4d7485 on nlohmann:master.

@nlohmann
Copy link
Owner

nlohmann commented Feb 5, 2015

Hi @Zoadian, sorry for not answering earlier. Though I like the idea of having a Windows version, I am currently working on new code that uses even more C++11 features. When I look at your code, I see that you mostly use the preprocessor to exclude those parts that are not yet supported by Visual Studio. I think I would rather wait until Visual Studio has true C++11 support rather than to fragmentize the project like this - in the end, I am using this project to learn the new C++11 features.

I'm going to close the pull request here, but I would be happy if you would host a Windows-compatible version yourself. I would link to it in the README. You might also want to get in touch with @kirkshoop. Kirk opened a similar pull request #29 earlier.

@nlohmann nlohmann closed this Feb 5, 2015
@nlohmann
Copy link
Owner

nlohmann commented Feb 5, 2015

Oh, I forgot. The error you mentioned is indeed a mistake. I will fix it soonish.

GerHobbelt pushed a commit to GerHobbelt/nlohmann-json that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants