Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid BJData optimized type, fix #3461 #3463

Merged
merged 2 commits into from
May 1, 2022
Merged

Handle invalid BJData optimized type, fix #3461 #3463

merged 2 commits into from
May 1, 2022

Conversation

fangq
Copy link
Contributor

@fangq fangq commented May 1, 2022

This patch should fix #3461. Tested both with the fuzzer unit and the unit-test.

@fangq fangq requested a review from nlohmann as a code owner May 1, 2022 02:18
@nlohmann
Copy link
Owner

nlohmann commented May 1, 2022

Please update to the latest develop branch (we renamed some folders in #3462).

@nlohmann nlohmann added the please rebase Please rebase your branch to origin/develop label May 1, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 96bf143 on NeuroJSON:fix3461 into 0c698b7 on nlohmann:develop.

falbrechtskirchinger
falbrechtskirchinger reviewed May 1, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential issue. Looks good otherwise.

include/nlohmann/detail/input/binary_reader.hpp Show resolved Hide resolved
@nlohmann nlohmann mentioned this pull request May 1, 2022
Merged
3 tasks
@nlohmann nlohmann added aspect: binary formats BSON, CBOR, MessagePack, UBJSON release item: 🐛 bug fix and removed please rebase Please rebase your branch to origin/develop labels May 1, 2022
nlohmann
nlohmann approved these changes May 1, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this May 1, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone May 1, 2022
@nlohmann nlohmann merged commit b205361 into nlohmann:develop May 1, 2022
@nlohmann
Copy link
Owner

nlohmann commented May 1, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger left review comments

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
aspect: binary formats BSON, CBOR, MessagePack, UBJSON release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

json:parse_bjdata_fuzzer reaches assertion
4 participants
@fangq @nlohmann @coveralls @falbrechtskirchinger