Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for comparing json and ordered_json #3599

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Add documentation for comparing json and ordered_json #3599

merged 2 commits into from
Jul 23, 2022

Conversation

nlohmann
Copy link
Owner

Closes #3443

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jul 23, 2022
@coveralls
Copy link

coveralls commented Jul 23, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8904546 on issue3443_ordered_json_comparison into e91686c on develop.

@nlohmann @falbrechtskirchinger
Apply suggestions from code review
8904546 
Co-authored-by: Florian Albrechtskirchinger <[email protected]>
@nlohmann nlohmann added release item: 🔨 further change and removed review needed It would be great if someone could review the proposed changes. labels Jul 23, 2022
@nlohmann nlohmann self-assigned this Jul 23, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 23, 2022
@nlohmann nlohmann merged commit 2d48a4d into develop Jul 23, 2022
@nlohmann nlohmann deleted the issue3443_ordered_json_comparison branch July 23, 2022 18:54
@akontsevich
Copy link

I would extend the doc. Still not clear how to compare different JSON types. I converted one to another first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger requested changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

ordered_json vs json types comparison
4 participants
@nlohmann @coveralls @akontsevich @falbrechtskirchinger