Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish documentation on push to develop branch #3660

Merged
merged 15 commits into from
Aug 3, 2022
Merged

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Aug 3, 2022

Changes

  • add workflow to publish documentation on push to develop branch
  • minor changes:
    • make sure bash is used in docset Makefile (not needed here, but calling the Makefile in GitHub actions yielded errors, because /bin/sh was used as default shell)
    • bump version of plantuml-markdown package

Notes

The concurrency setting make sure that no two jobs of the workflow run concurrently. Jobs are waiting until previous jobs complete:

Screen Shot 2022-08-03 at 10 11 27

@nlohmann nlohmann added documentation review needed It would be great if someone could review the proposed changes. labels Aug 3, 2022
@coveralls
Copy link

coveralls commented Aug 3, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling ff108a3 on documentation_update into 2ac7d02 on develop.

@falbrechtskirchinger
Copy link
Contributor

  • make sure bash is used in docset Makefile (not needed here, but calling the Makefile in GitHub actions yielded errors, because /bin/sh was used as default shell)

FYI, /bin/sh is symlinked to dash on Ubuntu.

@nlohmann
Copy link
Owner Author

nlohmann commented Aug 3, 2022

FYI, /bin/sh is symlinked to dash on Ubuntu.

Alright. It still did not work. I was trying to have an up-to-date docset somewhere, but the artifacts of GitHub are not too useful here.

Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

.github/workflows/publish_documentation.yml Outdated Show resolved Hide resolved
@nlohmann nlohmann removed the review needed It would be great if someone could review the proposed changes. label Aug 3, 2022
@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 3, 2022
@nlohmann nlohmann merged commit 98d70d4 into develop Aug 3, 2022
@nlohmann nlohmann deleted the documentation_update branch August 3, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants