-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Check amalgamation' workflow #3693
Add 'Check amalgamation' workflow #3693
Conversation
f61eecc
to
36023cd
Compare
8685b2b
to
dabe7a1
Compare
dabe7a1
to
df5d60b
Compare
df5d60b
to
03aecc7
Compare
@nlohmann The We still need |
0bb4035
to
e122745
Compare
@nlohmann After the pending PR touching workflows and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Add a workflow that checks if the sources have been amalgamated and leaves a comment directing to the Contribution Guidelines if they are not.
Because commenting on a PR requires write permission, there are two options for implementing this:
ci_test_amalgamation
target.pull_request
to run theci_test_amalgamation
target.workflow_run
to submit the comment.The downside to option 2 is that the workflow submitting the comment will run after the main workflows have mostly been completed. This PR implements option 1.
Because of
pull_request_target
, for security reasons, this workflow won't take effect until merged into the main branch.I've tested the workflow in my fork.
First-time contributors will see this message: falbrechtskirchinger#3 (comment)
Everyone else: falbrechtskirchinger#3 (comment)
The
check_amalgamation.yml
workflow should be excluded from the required checks for merging and enabled for first-time contributors.