Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in .md files #3748

Merged
merged 3 commits into from
Sep 17, 2022
Merged

Fix typos in .md files #3748

merged 3 commits into from
Sep 17, 2022

Conversation

tocic
Copy link
Contributor

@tocic tocic commented Sep 15, 2022

No description provided.

@request-info
Copy link

request-info bot commented Sep 15, 2022

We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template.

@request-info request-info bot added the state: needs more info the author of the issue needs to provide more details label Sep 15, 2022
falbrechtskirchinger
falbrechtskirchinger suggested changes Sep 15, 2022
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/api/basic_json/update.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/api/macros/nlohmann_json_serialize_enum.md Outdated Show resolved Hide resolved
tocic and others added 2 commits September 16, 2022 08:36
@tocic @falbrechtskirchinger
amend! Fix typos in .md files
f1b3190 
Fix typos in .md files

Co-authored-by: Florian Albrechtskirchinger <[email protected]>
@falbrechtskirchinger @tocic
squash! Fix typos in .md files
49e4470
@tocic tocic requested review from falbrechtskirchinger and removed request for nlohmann September 16, 2022 05:48
falbrechtskirchinger
falbrechtskirchinger approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 49e4470 on tocic:fix/md_typos into 58bd97e on nlohmann:develop.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Sep 17, 2022
@nlohmann nlohmann merged commit 9dfa722 into nlohmann:develop Sep 17, 2022
@nlohmann
Copy link
Owner

Thanks!

@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger approved these changes

Assignees
No one assigned
Labels
documentation M state: needs more info the author of the issue needs to provide more details
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tocic @coveralls @nlohmann @falbrechtskirchinger