Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error with _HAS_STATIC_RTTI=0 #4046

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Fix compile error with _HAS_STATIC_RTTI=0 #4046

merged 4 commits into from
Sep 24, 2023

Conversation

ALF-ONE
Copy link
Contributor

@ALF-ONE ALF-ONE commented Jun 4, 2023

Fix compile error with _HAS_STATIC_RTTI=0
See: https://github.com/microsoft/STL/blob/main/stl/inc/any#L15


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@ALF-ONE ALF-ONE requested a review from nlohmann as a code owner June 4, 2023 12:38
@github-actions github-actions bot added the M label Jun 4, 2023
@nlohmann
Copy link
Owner

nlohmann commented Jun 4, 2023

Can you please add some documentation to this (see https://github.com/nlohmann/json/blob/develop/docs/mkdocs/docs/api/macros/json_no_io.md for example). Furthermore, is there an issue that this MR is closing?

@coveralls
Copy link

coveralls commented Jun 4, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling dbc6a1d on ALF-ONE:develop into c71ecde on nlohmann:develop.

@ALF-ONE ALF-ONE changed the title Fix compile error with _HAS_STATIC_RTTI=1 Fix compile error with _HAS_STATIC_RTTI=0 Jun 5, 2023
@nlohmann nlohmann added the please rebase Please rebase your branch to origin/develop label Jun 11, 2023
@nlohmann
Copy link
Owner

Please update to the latest develop to have a fixed CI.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Sep 24, 2023
@nlohmann nlohmann merged commit 6d4b72d into nlohmann:develop Sep 24, 2023
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation M please rebase Please rebase your branch to origin/develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants