Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTF8 encoding enhancement #534

Merged
merged 1 commit into from
Mar 24, 2017
Merged

UTF8 encoding enhancement #534

merged 1 commit into from
Mar 24, 2017

Conversation

TedLyngmo
Copy link
Contributor

Remove the bitmask from the first utf8 octet for codepoints > 0x7f. The range check and bit shift already makes sure that the result is ok.

@TedLyngmo
Copy link
Contributor Author

So, coveralls/10757553 is hanging just like my previous attempts.
The travis build reported successfully to coveralls/24178102 which looks fine.
Is there perhaps some mismatch in the reporting of the coverage data or have I messed up somehow?

@nlohmann nlohmann merged commit bba688f into nlohmann:develop Mar 24, 2017
@nlohmann
Copy link
Owner

Thanks!

@nlohmann nlohmann self-assigned this Mar 24, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Mar 24, 2017
nlohmann added a commit that referenced this pull request Mar 24, 2017
@nlohmann
📝 update after #534
3d597dd
@TedLyngmo TedLyngmo deleted the utf8_encoding_enhancement branch March 24, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
kind: enhancement/improvement
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TedLyngmo @nlohmann