Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transparent comparator and perfect forwarding support to find() and count() #795

Merged
merged 9 commits into from
Oct 27, 2017
Merged

Add transparent comparator and perfect forwarding support to find() and count() #795

merged 9 commits into from
Oct 27, 2017

Commits on Oct 21, 2017

  1. Add string_view support 

    This avoids unnecessary string copies on often used
find().
    @jseward
    jseward committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    1a66679 View commit details
    Browse the repository at this point in the history

  2. Fix for _HAS_CXX17 == 0 

    Copied from solution to nlohmann#464
    @jseward
    jseward committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    59cde1a View commit details
    Browse the repository at this point in the history

  3. Use consistent logic to determine if string_view exists

    @jseward
    jseward committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    d468f8c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. Remove JSON_HAS_STRING_VIEW 

    Instead implement @gregmarr's PR comments that perfect forwarding should be used. Also cleaned up cpp language standard detection.
    @jseward
    jseward committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    33c6511 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2017

  1. Remove tabs for spaces

    @jseward
    jseward committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    73b1629 View commit details
    Browse the repository at this point in the history

  2. Remove c++17 support flag in cmake 

    Already covered by AppVeyor
    @jseward
    jseward committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    16ffdbc View commit details
    Browse the repository at this point in the history

  3. Remove old non-perfect forwarding find and count

    @jseward
    jseward committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    6c9a401 View commit details
    Browse the repository at this point in the history

  4. Remove extra spaces

    @jseward
    jseward committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    715c98b View commit details
    Browse the repository at this point in the history

  5. Add missing spaces

    @jseward
    jseward committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    992c836 View commit details
    Browse the repository at this point in the history