Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Std allocator conformance cpp17 #856

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Std allocator conformance cpp17 #856

merged 2 commits into from
Dec 6, 2017

Conversation

bogemic
Copy link
Contributor

@bogemic bogemic commented Dec 5, 2017

improved conformance with C++17, some members of std::allocator are deprecated and should be used via std::allocator_traits


Pull request checklist

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.8 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@trilogy-service-ro
Copy link

Can one of the admins verify this patch?

@nlohmann
Copy link
Owner

nlohmann commented Dec 5, 2017

@bogemic Could you please rebase to the latest develop branch?

@nlohmann nlohmann added the platform: visual studio related to MSVC label Dec 5, 2017
@bogemic
Copy link
Contributor Author

bogemic commented Dec 6, 2017

ok, rebase done

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8890b93 on bogemic:std_allocator_conformance_cpp17 into 0e3a0b7 on nlohmann:develop.

@nlohmann nlohmann self-assigned this Dec 6, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Dec 6, 2017
@nlohmann nlohmann removed the platform: visual studio related to MSVC label Dec 6, 2017
@nlohmann nlohmann merged commit c5e7317 into nlohmann:develop Dec 6, 2017
@nlohmann
Copy link
Owner

nlohmann commented Dec 6, 2017

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants