Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Includes CTest module/adds BUILD_TESTING option #885

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Includes CTest module/adds BUILD_TESTING option #885

merged 1 commit into from
Dec 23, 2017

Conversation

TinyTinni
Copy link
Contributor

PR for issue #846

@TinyTinni TinyTinni mentioned this pull request Dec 20, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d1cda68 on TinyTinni:develop into 88ddb12 on nlohmann:develop.

nlohmann
nlohmann approved these changes Dec 23, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Dec 23, 2017
@nlohmann nlohmann added this to the Release 3.0.1 milestone Dec 23, 2017
@nlohmann nlohmann merged commit 184e9c6 into nlohmann:develop Dec 23, 2017
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@TinyTinni @coveralls @nlohmann