Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Drafts - Not all previous drafts or future draft are showing #240

Closed
dawghouse73 opened this issue Jul 29, 2023 · 2 comments · Fixed by #251
Closed

[BUG] Drafts - Not all previous drafts or future draft are showing #240

dawghouse73 opened this issue Jul 29, 2023 · 2 comments · Fixed by #251
Assignees
Labels
bug Something isn't working

Comments

@dawghouse73
Copy link

Describe the bug
Related to discussion #223

Currently, by default, our Drafts page shows two items:

  • Next Season Draft Board (2024)
  • Rookie Draft (held in May 2023)

What's missing:

  • Our Initial Veterans Only Start Up draft from February 2023
  • The Draft Board for 2025
  • We allow the trading of picks for the next rookie draft and the following rookie draft. It would be nice to see the board and the picks owned by each manager for both next year and the year after. What I'm hoping to be able to see is the following:

What I'm hoping we can have show is:

  • Current Year + 1 Draft Board (ex. 2024)
  • Current Year + 2 Draft Board (ex. 2025)
  • Most Recent Rookie Draft for each year (ex. 2023)
  • Inaugural Draft (ex. for us it was earlier in 2023)

I know the API can pull this information (I've pulled it into Google sheets already), I think it just needs a check to see if there were more than one draft in a year (we split our start up and rookie drafts in year 1).
And as a bonus, maybe a configuration setting to allow us to pull in either 1 or 2 or 3 future years draft boards (Sleeper currently allows draft pick trading for up to 3 future years (it cannot restrict to more or to less - it's always three).
Our league allows for picks to be traded for 2 future years, so a setting in leagueinfo.js or somewhere to allow us to set 1, 2, or 3 future years which would then drive how many future boards are showing.

This issue is a combination of a a bug (missing 2025 draft, missing Inaugural Draft) and an enhancement (configuration to allow for 1-2-3 future draft boards to be shown via leagueinfo.js).

Your League ID
League ID: 922637695908737024
Site: shulacesoutdan.vercel.app

To Reproduce
Steps to reproduce the behavior:

  1. Go the League Info menu
  2. Click on Drafts

Expected behavior
When comparing to the Legends League page, they show all drafts (I believe), including their inaugural draft.
All previous Rookie Drafts are showing back to 2020.
The inaugural draft in 2019 is showing.
Next year's 2024 draft board is showing.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome (15.0.5790.110);
  • Browser: Opera (99.0.4788.88)
  • Browser: Firefox (115.0.2)
  • Browser: Edge (115.0.1901.188)

Smartphone (please complete the following information):

  • Device: iPhone12
  • OS: iOS16.1.1
  • Browser: Chrome (115.0.5790.130)
  • Browser: Safari (v16)

Additional context
All existing draft data is showing accurately.

@dawghouse73 dawghouse73 added the bug Something isn't working label Jul 29, 2023
@nmelhado nmelhado linked a pull request Aug 21, 2023 that will close this issue
@nmelhado
Copy link
Owner

@dawghouse73 the bug portion of this is fixed! Feel free to open up a new ticket requesting additional future draft boards

@dawghouse73
Copy link
Author

dawghouse73 commented Aug 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants