Implementing jquery events #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JemarJones It looks good to me. I just updated README.md because there were still some paths there referencing the old version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take on implementing the feature discussed in #32. jQuery has actually made it dead easy to create custom events which was nice to explore. I've added two events that you can now use in the normal jQuery way,
flip:done, which is triggered on the completion of a flip andflip:changewhich is triggered upon the completion of setting/changing a property. I've opted not to provide an event for the completion of an initial setup because thats an event that should only ever take place once and therefore the already built in callback should be sufficient. I've chosen these slightly more unique event names just in case theres ever another event out there nameflip. Implementation wise i basically just had to trigger the events right before the normal callback is called.Any comments/concerns?