Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing jquery events #34

Merged
merged 9 commits into from
Jul 18, 2015
Merged

Implementing jquery events #34

merged 9 commits into from
Jul 18, 2015

Conversation

JemarJones
Copy link
Collaborator

This is my take on implementing the feature discussed in #32. jQuery has actually made it dead easy to create custom events which was nice to explore. I've added two events that you can now use in the normal jQuery way, flip:done, which is triggered on the completion of a flip and flip:change which is triggered upon the completion of setting/changing a property. I've opted not to provide an event for the completion of an initial setup because thats an event that should only ever take place once and therefore the already built in callback should be sufficient. I've chosen these slightly more unique event names just in case theres ever another event out there name flip. Implementation wise i basically just had to trigger the events right before the normal callback is called.

Any comments/concerns?

@Download
Copy link
Collaborator

@JemarJones It looks good to me. I just updated README.md because there were still some paths there referencing the old version.

JemarJones added a commit that referenced this pull request Jul 18, 2015
@JemarJones JemarJones merged commit cfc8dc3 into master Jul 18, 2015
@JemarJones JemarJones deleted the eventcallback branch July 18, 2015 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants