Skip to content

Code Review Guideline

Jump to bottom
Jinsu Park edited this page Jan 1, 2021 · 1 revision

์šฐ๋ฆฌ๋งŒ์˜ Step by Step

  • ๋ฆฌ๋ทฐ๋ฅผ ์œ„ํ•œ ๋ฆฌ๋ทฐ๋ฅผ ์–ต์ง€๋กœ ํ•˜์ง€๋งˆ๋ผ. ๋Œ€์‹  ํ”ผ๋“œ๋ฐฑํ•  ๊ฒŒ ์—†์œผ๋ฉด ์นญ์ฐฌํ•˜๋ผ.
  • ๊ตฌํ˜„์„ ์ž˜ํ•œ ๋ถ€๋ถ„์— ๋Œ€ํ•ด ์นญ์ฐฌ์˜ ๋ฉ”์‹œ์ง€๋ฅผ ๋‚จ๊ฒจ๋ผ.
  • ๋‚ด๊ฐ€ ๊ฒฐ์ •ํ•˜์ง€ ๋ง๊ณ  ์ƒ๋Œ€๋ฐฉ์ด ์„ ํƒํ•˜๋„๋ก ํ•˜๋ผ.
  • ๋– ๋จน์—ฌ์ฃผ์ง€ ์•Š๋Š” ์นœ์ ˆํ•จ์„ ์—ฐ์Šตํ•˜๋ผ(Practice kindness)
  • ์ด์œ ์™€ ํ•จ๊ป˜ ์˜ˆ์‹œ๋กœ ์„ค๋ช…ํ•˜๋ผ(Explain why&with examples)
  • ๊ฐ ๋‹จ๊ณ„๋ณ„ Request Changes๋Š” 1ํšŒ ์ด๋‚ด๋กœ ํ•œ๋‹ค.( ํฐ ๊ฒฐ์ ์ด ์•„๋‹ˆ๋ฉด Mergeํ•˜๊ณ  ์ด์œ ๋ฅผ ์ ์–ด๋‘”๋‹ค)
  • ๋ฆฌ๋ทฐ๋ฅผ ํ™•์ธํ•˜๋ฉด ์ด๋ชจ์ง€ ๋‹ฌ์•„๋‘๊ธฐ
Clone this wiki locally