[Trivial] Unnecessary comments Removed

Comments removed from the code. Signed-off-by: Yash Singh <[email protected]>
nnstreamer · Aug 29, 2024 · 9eaca55 · 9eaca55
1 parent 2e1d2d9
commit 9eaca55
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 23 deletions.
diff --git a/nntrainer/tensor/cl_operations/attention_kernels.cpp b/nntrainer/tensor/cl_operations/attention_kernels.cpp
@@ -59,7 +59,6 @@ __kernel void rotary_emb_cl(__global float *input,
                 transformed_value = input[b * channel * height * width + c * height * width + h * width + span - half_];
               }
               value = value * cos_ptr[k] + transformed_value * sin_ptr[k];
-              // printf("GPU Batch: %u, Height: %u, Channel: %u, Width: %u, K: %u, Span: %u, Value: %f, Transformed Value: %f, cos_ptr[k]: %f, sin_ptr[k]: %f\n",  b, h, c, w, k, span, value, transformed_value, cos_ptr[k], sin_ptr[k]);
               output[b * channel * height * width + c * height * width + h * width + span] = value;
             }
           }

diff --git a/nntrainer/tensor/cl_operations/attention_kernels_fp16.cpp b/nntrainer/tensor/cl_operations/attention_kernels_fp16.cpp
@@ -144,14 +144,14 @@ void rotary_emb_cl(__fp16 *in, __fp16 *out,
     result = freqs_cosBuf.WriteData(context.command_queue_inst_,
                                     freqs_cos_flat.data());
     if (!result) {
-      printf("Failed to write cos data\n");
+      printf("Failed to write freqs cos data\n");
       break;
     }
 
     result = freqs_sinBuf.WriteData(context.command_queue_inst_,
                                     freqs_sin_flat.data());
     if (!result) {
-      printf("Failed to write sin data\n");
+      printf("Failed to write freqs sin data\n");
       break;
     }
 

diff --git a/nntrainer/tensor/cl_operations/testing_rotarty_emb.cpp b/nntrainer/tensor/cl_operations/testing_rotarty_emb.cpp
@@ -42,10 +42,6 @@ void precompute_freqs(int dim, unsigned int seq_len,
     sin.assign(seq_len, std::vector<float>(dim, 0));
 
     for (unsigned int i = 0; i < seq_len; ++i) {
-#ifdef USE_NEON
-      nntrainer::calc_trigonometric_vals_dup(half_, freqs.data(), cos[i].data(),
-                                             sin[i].data(), i);
-#else
       for (unsigned int j = 0; j < half_; ++j) {
         float angle = i * freqs[j];
         cos[i][j] = std::cos(angle);
@@ -54,7 +50,6 @@ void precompute_freqs(int dim, unsigned int seq_len,
         sin[i][j] = std::sin(angle);
         sin[i][j + half_] = std::sin(angle); // repeated 2 times
       }
-#endif
     }
     freqs_cos = cos;
     freqs_sin = sin;
@@ -87,10 +82,6 @@ void apply_rotary_emb_tensor(nntrainer::Tensor &in, unsigned int dim,
   if (from >= max_timestep) {
     cos_ = std::vector<float>(dim);
     sin_ = std::vector<float>(dim);
-#ifdef USE_NEON
-    nntrainer::calc_trigonometric_vals_dup(half_, freqs.data(), cos_.data(),
-                                           sin_.data(), from);
-#else
     for (unsigned int i = 0; i < half_; ++i) {
       float angle = from * freqs[i];
       cos_[i] = std::cos(angle);
@@ -99,7 +90,6 @@ void apply_rotary_emb_tensor(nntrainer::Tensor &in, unsigned int dim,
       sin_[i] = std::sin(angle);
       sin_[i + half_] = std::sin(angle); // repeated 2 times
     }
-#endif
   } else {
     cos_.resize(max_timestep);
     sin_.resize(max_timestep);
@@ -133,10 +123,6 @@ void apply_rotary_emb_tensor(nntrainer::Tensor &in, unsigned int dim,
                   transformed_value = in.getValue<float>(b, c, h, span - half_);
                 }
                 value = value * cos_[k] + transformed_value * sin_[k];
-                // printf("CPU Batch: %u, Channel: %u, Height: %u, Width: %u, K:
-                // %u, Span: %u, Value: %f, Transformed Value: %f, cos_ptr[k]:
-                // %f, sin_ptr[k]: %f\n ",  b, c, h, w, k, span, value,
-                // transformed_value, cos_[k], sin_[k]);
                 out.setValue(b, c, h, span, value);
               }
             }

diff --git a/test/unittest/unittest_attention_kernels_cl.cpp b/test/unittest/unittest_attention_kernels_cl.cpp
@@ -65,12 +65,6 @@ TEST(attention_kernels, rotary_emb_kernel_FP32) {
 
   B_fp32.copy(A_fp32);
 
-  // std::cout << "\nA_fp32 and B_fp32 before rotary embedding:" << std::endl;
-  // for (unsigned int i = 0; i < A_fp32.size(); ++i) {
-  //   std::cout << "Element " << i << " -> " << *(A_fp32.getData<float>() + i)
-  //   <<"\t"<<*(B_fp32.getData<float>() + i)<< std::endl;
-  // }
-
   apply_rotary_emb_cl(A_fp32, dim, from, max_timestep, rc);
   apply_rotary_emb_tensor(B_fp32, dim, from, max_timestep);