Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wait for #2720][CI] Fix meson ubuntu ci build #2716

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

DonghakPark
Copy link
Member

Fix build bug

  • Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
  • Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK [email protected]
Co-authored-by: hyeonseok [email protected]
Co-authored-by: Donghyeon Jeong [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 23, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2716. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@DonghakPark DonghakPark force-pushed the fix_ubuntu_build branch 5 times, most recently from bb67730 to 5b2ca0b Compare August 23, 2024 04:31
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonghakPark
Copy link
Member Author

It is normal to fail because the CI has not been working properly so far. Additionally, for the current changes, instead of deleting directories, each name was changed differently, and the meson setup was removed.

@DonghakPark
Copy link
Member Author

For clarity's sake, let me provide some comments.

So far, the reason why Meson build & Ninja tests have not been working as intended is due to the redundant usage of both 'meson setup build' and 'meson build'.

In addition to this, I initially thought that jobs in GitAction would run within the same container but with @myungjoo help, I realized it was unnecessary to separate the names of build directories, so I made adjustments accordingly.

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 27, 2024

:octocat: cibot: @DonghakPark, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2716-202408271336310.14494490623474-51bab61d62ed75d36fdea5e592030e2b94c9afee/.

@DonghakPark DonghakPark force-pushed the fix_ubuntu_build branch 2 times, most recently from b890eda to 64e2d0c Compare August 27, 2024 05:27
@DonghakPark DonghakPark force-pushed the fix_ubuntu_build branch 3 times, most recently from 9e2e91a to d56c8a7 Compare August 27, 2024 05:53
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo
Copy link
Member

For gcc-13 in Ubuntu Jammy, use ppa:ubuntu-toolchain-r/test instead of ppa:ubuntu-toolchain-r/ppa

@DonghakPark DonghakPark force-pushed the fix_ubuntu_build branch 2 times, most recently from 5d79355 to 7cdfbfb Compare August 28, 2024 07:36
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

@DonghakPark DonghakPark changed the title [CI] Fix meson ubuntu ci build [Wait for #2720][CI] Fix meson ubuntu ci build Aug 29, 2024
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch properly uses gcc-13 & build and run with enable-fp16=true 👍 I think it is good to go :) nice work!

.github/workflows/ubuntu_clean_meson_build.yml Outdated Show resolved Hide resolved
.github/workflows/ubuntu_clean_meson_build.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
- This commit adds some updates for Tizen7.0 backporting
- Type mismatch bug is fixed.
- Unused variable is removed.
- Missing header files are added in spec file.
- spec file is updated

Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Eunju Yang <[email protected]>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

@DonghakPark DonghakPark self-assigned this Sep 5, 2024
@jijoongmoon jijoongmoon merged commit e025352 into nnstreamer:main Sep 6, 2024
37 checks passed
@DonghakPark DonghakPark deleted the fix_ubuntu_build branch October 21, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants