[bugfix] fix coverity issues #2722
Conversation
This PR resolves coverity issues in the ShortTensor class. Replace max_abs() implementation with maxValue() since the maximum absolute value of unsigned int equals to the maximum value. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
EunjuYang and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2722. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
I agree. I think it would be better to have something that clarifies its characteristics such as |
|
|
||
| return max_val; | ||
| } | ||
| float ShortTensor::max_abs() const { return maxValue(); } | ||
|
|
||
| float ShortTensor::maxValue() const { |
There was a problem hiding this comment.
And just curious, if this tensor is containing 'unsigned' integer, why should it be max_"abs" ? it is already absolute.
There was a problem hiding this comment.
sorry I didn't quite understand. do you mean why max_abs() should be used?
There was a problem hiding this comment.
Yes. I think can't see any difference between maxValue and maxAbsoluteValue for this tensor
There was a problem hiding this comment.
You're right! There's no difference between max_abs() and maxValue() for this tensor class. That's why max_abs() is using maxValue(). The reason why there are max_abs() and maxValue() is to be compatible with the TensorBase and Tensor class. While max_abs() is currently a pure virtual function, it will get a compile error without implementing max_abs() in the ShortTensor class.
This PR resolves coverity issues in the ShortTensor class. Replace max_abs() implementation with maxValue() since the maximum absolute value of unsigned int equals to the maximum value.
Self-evaluation: