Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverity] fix coverity issue @open sesame 10/02 11:44 #2739

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[coverity] fix coverity issue @open sesame 10/02 11:44 #2739

merged 1 commit into from
Oct 16, 2024

Conversation

djeong20
Copy link
Contributor

This PR resolves the issue by checking what the malloc function returned

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 25, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2739. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@djeong20
[coverity] fix coverity issue
f3560cb 
This PR resolves the issue by checking what the malloc function returned

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
taos-ci
taos-ci approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

skykongkong8
skykongkong8 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will keep this issue in further code as well!

@djeong20 djeong20 added the PR/OK2GO CI failed but okay to merge/review label Sep 25, 2024
songgot
songgot approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@djeong20
Copy link
Contributor Author

The current CI failure is a known issue #2486 unrelated to the current patch.

@skykongkong8
Copy link
Member

The current CI failure is a known issue #2486 unrelated to the current patch.

Yes.. but #2740 #2739 #2737 #2736
are showing the same failure for

...
[ 1349s] [  FAILED  ] CacheLoaderTest.load_async_02_p
...

I think this is not an issue for this PR, but isn't it quite different from what we experienced so far?

SeoHyungjun
SeoHyungjun approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@SeoHyungjun SeoHyungjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EunjuYang
EunjuYang approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Always thank you for checking the coverity issue :)

@jijoongmoon jijoongmoon changed the title [coverity] fix coverity issue [coverity] fix coverity issue @open sesame 10/02 11:44 Oct 2, 2024
taos-ci
taos-ci approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

lhs8928
lhs8928 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baek2sm
baek2sm approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit fa9aa03 into nnstreamer:main Oct 16, 2024
52 checks passed
@djeong20 djeong20 deleted the fix/coverity/092524 branch October 16, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@taos-ci taos-ci taos-ci approved these changes

@songgot songgot songgot approved these changes

@SeoHyungjun SeoHyungjun SeoHyungjun approved these changes

@baek2sm baek2sm baek2sm approved these changes

@lhs8928 lhs8928 lhs8928 approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

Assignees
No one assigned
Labels
PR/OK2GO CI failed but okay to merge/review PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@djeong20 @taos-ci @skykongkong8 @EunjuYang @lhs8928 @baek2sm @SeoHyungjun @songgot @DonghakPark @jijoongmoon