Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[header] add missing headers @open sesame 10/02 11:44 #2742

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[header] add missing headers @open sesame 10/02 11:44 #2742

merged 1 commit into from
Oct 18, 2024

Conversation

lhs8928
Copy link
Contributor

@lhs8928 lhs8928 commented Sep 30, 2024

  • Added missing header

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 30, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2742. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

EunjuYang
EunjuYang approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DonghakPark
DonghakPark approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! but check CI (commit msg length maybe)

taos-ci
taos-ci approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhs8928, 💯 All CI checkers are successfully verified. Thanks.

djeong20
djeong20 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

skykongkong8
skykongkong8 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon changed the title [header] add missing headers [header] add missing headers @open sesame 10/02 11:44 Oct 2, 2024
taos-ci
taos-ci approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhs8928, 💯 All CI checkers are successfully verified. Thanks.

@DonghakPark
Copy link
Member

DonghakPark commented Oct 2, 2024 •
edited
Loading

Please Rebase (upstream/main), #2741 resolve cacheLoader_test_case issue

SeoHyungjun
SeoHyungjun approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@SeoHyungjun SeoHyungjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhs8928
[header] add missing headers
3d1ffa3 
 - Added missing header "algorithm"

Signed-off-by: hyeonseok <[email protected]>
taos-ci
taos-ci approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhs8928, 💯 All CI checkers are successfully verified. Thanks.

baek2sm
baek2sm approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit bae241b into nnstreamer:main Oct 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@djeong20 djeong20 djeong20 approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@taos-ci taos-ci taos-ci approved these changes

@SeoHyungjun SeoHyungjun SeoHyungjun approved these changes

@baek2sm baek2sm baek2sm approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lhs8928 @taos-ci @DonghakPark @EunjuYang @baek2sm @SeoHyungjun @djeong20 @skykongkong8 @jijoongmoon