Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ unittest/modelfile ] Fix backbone_20 @open sesame 10/25 10:21 #2771

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

skykongkong8
Copy link
Member

  • Previous network was using hard-coded same-named layers, thus connecting convolution layer with invalid input layer.
    This caused :
    "Failed to initialize: in size + padding is smaller than effective kernel" thrown in the test body.
  • Differentiate input layer names, and fix corresponding network size, which is 10:
    mse0, fclayer/act_realized, fclayer, flat, inputlayer2d, mse1, inputlayer/act_realized, conv2d/activation_realized, conv2d, inputlayer

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 24, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2771. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

@DonghakPark DonghakPark changed the title [ Wait for #2769 ] [ unittest/modelfile ] Fix backbone_20 [ Wait for #2769 ] [ unittest/modelfile ] Fix backbone_20 @open sesame 10/24 19:24 Oct 24, 2024
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

@skykongkong8 skykongkong8 changed the title [ Wait for #2769 ] [ unittest/modelfile ] Fix backbone_20 @open sesame 10/24 19:24 [ Wait for #2769 ] [ unittest/modelfile ] Fix backbone_20 @open sesame 10/25 10:21 Oct 25, 2024
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Previous network was using hard-coded same-named layers, thus connecting convolution layer with invalid input layer.
This caused :
`"Failed to initialize: in size + padding is smaller than effective kernel" thrown in the test body.`
- Differentiate input layer names, and fix corresponding network size, which is 10:
`mse0, fclayer/act_realized, fclayer, flat, inputlayer2d, mse1, inputlayer/act_realized, conv2d/activation_realized, conv2d, inputlayer`

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <[email protected]>
@skykongkong8 skykongkong8 changed the title [ Wait for #2769 ] [ unittest/modelfile ] Fix backbone_20 @open sesame 10/25 10:21 [ unittest/modelfile ] Fix backbone_20 @open sesame 10/25 10:21 Oct 27, 2024
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit 140991a into nnstreamer:main Oct 29, 2024
44 checks passed
@skykongkong8 skykongkong8 deleted the pr/modelfile/backbone20 branch October 29, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants