[ unittest ] Fix modelfile TCs @open sesame 11/07 16:09 #2788
Conversation
- Remove todo doxygen comments for resolved test cases that have been temporally commented-out **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: skykongkong8 <[email protected]>
- backbone_relative_to_ini_p : fix invalid bn layer param - backbone_08_n : insufficient init parameters should fail, thus wrong test status - backbone_09_n : current loadFromConfig does not return 'not supported' - buffer_size_smaller_than_batch_size_p, 2p : missing res directory - basic_dataset_p 1,2,3 : missing res directory **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: skykongkong8 <[email protected]>
skykongkong8
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm and
djeong20
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2788. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
skykongkong8
changed the title
There was a problem hiding this comment.
@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.
skykongkong8
changed the title
There was a problem hiding this comment.
@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.
| // #endif | ||
| // } | ||
| #if defined(ENABLE_NNSTREAMER_BACKBONE) || defined(ENABLE_TFLITE_BACKBONE) | ||
| EXPECT_EQ(NN.loadFromConfig(s.getIniName()), ML_ERROR_INVALID_PARAMETER); |
There was a problem hiding this comment.
It seems backbone_random_external from ScopdeIni is simply random.tflite; if ENABLE_TFLITE_BACKBONE is defined, shouldn't it expect ML_ERROR_NONE?
There was a problem hiding this comment.
You are correct, but we are already checking such case with backbone_valid_external from another TC, and I could not find any file for formulating random.tflite currently. I thought it is just a negative TC to emit error like this.
backbone_relative_to_ini_p: fix invalid bn layer parambackbone_08_n: insufficient init parameters should fail, thus wrong test statusbackbone_09_n: current loadFromConfig does not returnML_ERROR_NOT_SUPPORTED. Think this is deprecated. Instead,ML_INVALID_PARAMis thrown in current versionbuffer_size_smaller_than_batch_size_p,buffer_size_smaller_than_batch_size_2p: missing res directorybasic_dataset_p,basic_dataset2_p,basic_dataset3_p: missing res directorySelf evaluation:
Signed-off-by: skykongkong8 [email protected]