Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CMAKE_FORTRAN_COMPILER definition from CMakeList.txt #49

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

chan-hoo
Copy link
Contributor

@chan-hoo chan-hoo commented Apr 5, 2024

To resolve the issue #48, the dummy definition CMAKE_FORTRAN_COMPILER is removed from CMakeLists.txt.
Without it, nexus is compiled successfully on Hera, Orion, Hercules, and Derecho.

@zmoon
Copy link
Member

zmoon commented Apr 5, 2024

I agree that CMAKE_Fortran_COMPILER env/shell variable should not be required, though I would think you would generally want to set it anyway (or FC) for clarity and to be sure the correct compiler is used.

@chan-hoo
Copy link
Contributor Author

chan-hoo commented Apr 5, 2024

Yes, it is defined in the build module file for other machines, but Derecho doesn't want it.

@zmoon
Copy link
Member

zmoon commented Apr 5, 2024

Derecho doesn't want it

Interesting, do they say why?

@chan-hoo
Copy link
Contributor Author

chan-hoo commented Apr 5, 2024

Derecho doesn't want it

Interesting, do they say why?

I am reading through the docs. I'll let you know if I find it.

@zmoon zmoon merged commit 47d1ce4 into noaa-oar-arl:develop Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants