Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of NEMO NEI 2019 #54

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from
Draft

Conversation

drnimbusrain
Copy link
Member

@drnimbusrain drnimbusrain commented Aug 30, 2024

@bbakernoaa For the NEMO NEI2019 here, I assume this is what you meant by adding new config? I updated to NEI2109 based on the [develop] branch cmaq_gfs_megan config. Also not sure if we are targeting this NEI2019 update to the [develop] or [production/AQMv7] branch.

Also required changes to NEXUS utils such as the linker script, maybe @zmoon can help here, and then changes to workflow to do a test run.

@drnimbusrain drnimbusrain added the enhancement New feature or request label Aug 30, 2024
@drnimbusrain drnimbusrain linked an issue Aug 30, 2024 that may be closed by this pull request
@drnimbusrain drnimbusrain marked this pull request as draft August 30, 2024 17:00
@drnimbusrain
Copy link
Member Author

drnimbusrain commented Aug 30, 2024

Thanks @bbakernoaa

@zmoon can you help update the NEXUS utils/python linker scripts to this PR to accommodate these updates to use the NEMO/NEI2019 emissions. You can see examples of their emission files for correct linking on Hera at: /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/nexus/NEMO/NEI2019/v2023-03/$mm Instead of daily files, these merged 2D files are provided as four representative days (two weekdays and two weekend days) per month and could be linked accordingly for the NEXUS/HEMCO simulation date. Thanks!

@zmoon
Copy link
Member

zmoon commented Sep 6, 2024

Thanks @drnimbusrain , did you want me to do it in this branch?

@drnimbusrain
Copy link
Member Author

drnimbusrain commented Sep 6, 2024 via email

@drnimbusrain
Copy link
Member Author

Thanks @drnimbusrain , did you want me to do it in this branch?

@zmoon

@zmoon
Copy link
Member

zmoon commented Sep 27, 2024

@drnimbusrain here's a little example of what I've currently got set up:

> mkdir tmp
> ./nexus_nei2019_linker.py -s /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/nexus/ -w ./tmp --no_read_hemco_time -d 2023-09-27
file map size: 84
src dir: /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/nexus
work dir: ./tmp
date: 2023-09-27, month: 9, isoweekday: 3
linking /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/nexus/NEMO/NEI2019/v2023-03/09/NEI2019v1_0.1_degree_20190910_all.nc to ./tmp/NEMO/NEI2019/v2023-03/09/NEI2019v1_0.1_degree_20230927_all.nc

But besides adding this ability to test single dates, the CLI should be the same and you should be able to just swap for this new Python script in the workflow nexus emission Bash script.

@drnimbusrain
Copy link
Member Author

@drnimbusrain here's a little example of what I've currently got set up:

> mkdir tmp
> ./nexus_nei2019_linker.py -s /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/nexus/ -w ./tmp --no_read_hemco_time -d 2023-09-27
file map size: 84
src dir: /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/nexus
work dir: ./tmp
date: 2023-09-27, month: 9, isoweekday: 3
linking /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/nexus/NEMO/NEI2019/v2023-03/09/NEI2019v1_0.1_degree_20190910_all.nc to ./tmp/NEMO/NEI2019/v2023-03/09/NEI2019v1_0.1_degree_20230927_all.nc

But besides adding this ability to test single dates, the CLI should be the same and you should be able to just swap for this new Python script in the workflow nexus emission Bash script.

Ok, thank you Zach, let me test it with swapping the workflow's exaqm_nexus_emission.sh script to use this new python linker script. Ill make the necessary changes to the following places:

  1. https://github.com/ufs-community/ufs-srweather-app/blob/aqm_dev/scripts/exaqm_nexus_emission.sh#L214
  2. https://github.com/ufs-community/ufs-srweather-app/blob/aqm_dev/scripts/exaqm_nexus_emission.sh#L260-L277

For changes in 2 above, I assume there is not a new "nexus_nei2016_control_tilefix.py" script, and we still use this one, correct?

Thanks again!

@zmoon
Copy link
Member

zmoon commented Sep 30, 2024

not a new "nexus_nei2016_control_tilefix.py" script

May need to, let's see. It seems all it does is replace 2016$MM$DD with the target year. So for 2019 I suppose we would need to do the same, to replace the 2019 in 2019$MM$DD.

ROOT/NEMO/NEI2019/v2023-03/$MM/NEI2019v1_0.1_degree_2019$MM$DD_all.nc  

But could that line not be written like

ROOT/NEMO/NEI2019/v2023-03/$MM/NEI2019v1_0.1_degree_$YYYY$MM$DD_all.nc  

instead? Then the script to modify the NEXUS config shouldn't be needed?

@drnimbusrain : Yes, I it seems better that way, but for now will just add new one in case there is something else, maybe Barry can comment.

@drnimbusrain
Copy link
Member Author

Actually best way is to remove the year specific entirely and have the config be agnostic to this (as we do for some other global inventories), and use the configs as just "NEI" not NEI2016, NEI2019 etc. We should do this in the future.

@drnimbusrain
Copy link
Member Author

Actually best way is to remove the year specific entirely and have the config be agnostic to this (as we do for some other global inventories), and use the configs as just "NEI" not NEI2016, NEI2019 etc. We should do this in the future.

Well, not really sure about this either. I think we would want to maintain easy ways of testing any available inventory with simple switches, e.g., keeping both capabilities for NEI2016 vs. NEI2019, and going forward.

@drnimbusrain
Copy link
Member Author

@zmoon getting the following error for a August 01-07, 2023 test on Hera:

All executables will be submitted with command \'srun -n 80 --export=ALL\'.
2023-08-01 12:00:00 2023-08-01 17:00:00
2023-08-01 12:00:00
file map size: 36
src dir: /scratch2/NCEPDEV/naqfc/RRFS_CMAQ/emissions/nexus
work dir: /scratch1/NCEPDEV/stmp4/Patrick.C.Campbell/expt_dirs/aqmna13_gfs_v16_test_aqm_dev_cmaq54_nei2019/tmp/nexus_emission_00.414949/input
date: 2023-08-01, month: 8, isoweekday: 2
error: no file found for month 8, iwd 2
FATAL ERROR:
ERROR:

@drnimbusrain
Copy link
Member Author

Ah, hang on, I think I have another error in the workflow script with the incorrect version (-v) when running the linker script.

@drnimbusrain
Copy link
Member Author

drnimbusrain commented Oct 10, 2024

@zmoon @bbakernoaa The NEMO NEI2019 have been tested (against current NEI2016v1) in AQMv8 for August 01-07,2023:

Ozone Spatial Differences:
image
Ozone NMB Scorecard
image
Ozone NME Scorecard
image
Ozone IOA Scorecard
image

PM2.5 Spatial Differences
image
PM2.5 NMB Scorecard
image
PM2.5 NME Scorecard
image
PM2.5 IOA Scorecard
image

@drnimbusrain
Copy link
Member Author

Full evaluations of NEMO NEI2019 emissions updates on AQMv8 shown here: https://drive.google.com/drive/folders/1Dxl46SCrBNX_INiFiM-aU3K_IzJYy6wL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating NEXUS Inputs to use NEMO NEI 2019 Emissions
3 participants