Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW3 changes by @awest-noaa #103

Merged
8 commits merged into from
Apr 29, 2022
Merged

WW3 changes by @awest-noaa #103

8 commits merged into from
Apr 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2022

No description provided.

@ghost ghost linked an issue Mar 2, 2022 that may be closed by this pull request
9 tasks
@awest-noaa
Copy link
Contributor

Zach, before moving ahead with this, Takis still needs to make one correction to the ADCIRC submodule file adc_cap.F90 he and I discussed on Monday. Please check with him

@ghost
Copy link
Author

ghost commented Mar 2, 2022

Zach, before moving ahead with this, Takis still needs to make one correction to the ADCIRC submodule file adc_cap.F90 he and I discussed on Monday. Please check with him

Sure thing, I will keep this as a draft pull request until we get on the same page, thanks!

@ghost ghost requested review from awest-noaa and pvelissariou1 March 4, 2022 16:28
@ghost ghost self-assigned this Mar 4, 2022
@ghost
Copy link
Author

ghost commented Apr 28, 2022

I have rebased this branch on top of the changes made in the meantime to develop, so that these commits are linear and put on top (chronologically) and there are no merge conflicts. Additionally, I updated the ADCIRC submodule to point to the new NUOPC changes in the notre_dame branch that we recently rebased.

This pull request should be ready to merge after a review of the changes

@awest-noaa
Copy link
Contributor

@zacharyburnettNOAA thanks for these changes. As discussed yesterday, these can be tested using the following (offline) set of regtests on Hera: /scratch2/COASTAL/coastal/save/Andre.VanderWesthuysen/OCS-NEMS3/CoastalApp/regtests

@ghost ghost marked this pull request as ready for review April 29, 2022 16:20
@ghost ghost merged commit 1429d12 into develop Apr 29, 2022
@ghost
Copy link
Author

ghost commented Apr 29, 2022

@awest-noaa I have now merged this branch into develop, and we will work on adding the WW3 tests to develop shortly

@ghost ghost deleted the feature/ww3 branch April 29, 2022 16:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WW3/SCHSIM integration and CoastalApp pre-requirements
3 participants